Re: [patch] net: core: Correct the sock::sk_lock.owned lockdep annotations
From: patchwork-bot+netdevbpf
Date: Sun Sep 19 2021 - 08:10:20 EST
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 18 Sep 2021 14:42:35 +0200 (CEST) you wrote:
> lock_sock_fast() and lock_sock_nested() contain lockdep annotations for the
> sock::sk_lock.owned 'mutex'. sock::sk_lock.owned is not a regular mutex. It
> is just lockdep wise equivalent. In fact it's an open coded trivial mutex
> implementation with some interesting features.
>
> sock::sk_lock.slock is a regular spinlock protecting the 'mutex'
> representation sock::sk_lock.owned which is a plain boolean. If 'owned' is
> true, then some other task holds the 'mutex', otherwise it is uncontended.
> As this locking construct is obviously endangered by lock ordering issues as
> any other locking primitive it got lockdep annotated via a dedicated
> dependency map sock::sk_lock.dep_map which has to be updated at the lock
> and unlock sites.
>
> [...]
Here is the summary with links:
- net: core: Correct the sock::sk_lock.owned lockdep annotations
https://git.kernel.org/netdev/net/c/2dcb96bacce3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html