Re: [net-next PATCH 2/3] net: phy: at803x: add resume/suspend function to qca83xx phy

From: Andrew Lunn
Date: Sun Sep 19 2021 - 12:48:01 EST


> +static int qca83xx_suspend(struct phy_device *phydev)
> +{
> + phy_modify(phydev, MII_BMCR, 0, BMCR_PDOWN);
> +
> + return 0;
> +}
> +
> +static int qca83xx_resume(struct phy_device *phydev)
> +{
> + return phy_modify(phydev, MII_BMCR, BMCR_PDOWN, 0);
> +}
> +

genphy_suspend() and genphy_resume() do exactly this. Please use the
helpers.

Please also add a patch 0/3 which explains the big picture. It will be
used in the merge commit.

Andrew