Re: [PATCH] input: cm109: fix URB submitted while active

[Pavel Skripkin]

On 8/18/21 14:07, Pavel Skripkin wrote:
> On 8/4/21 5:58 PM, Pavel Skripkin wrote:
> > Syzbot reported, that dev->urb_ctl was submitted while active. The
> > problem was in missing validation check. We should check, that dev->urb_ctl
> > is not pending before sumbitting it again.
> >
> > Fail log:
> >
> > URB 00000000cfeee59c submitted while active
> > WARNING: CPU: 1 PID: 8459 at drivers/usb/core/urb.c:378 usb_submit_urb+0x1271/0x1540 drivers/usb/core/urb.c:378
> > ...
> > Call Trace:
> >   <IRQ>
> >   cm109_urb_irq_callback+0x44f/0xaa0 drivers/input/misc/cm109.c:422
> >   __usb_hcd_giveback_urb+0x2b0/0x5c0 drivers/usb/core/hcd.c:1656
> >   usb_hcd_giveback_urb+0x367/0x410 drivers/usb/core/hcd.c:1726
> >
> > Reported-and-tested-by: syzbot+2d6d691af5ab4b7e66df@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Fixes: c04148f915e5 ("Input: add driver for USB VoIP phones with CM109 chipset")
> > Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> > ---
>
>
> Gentle ping :)

Hi, Dmitry,

did you have a chance to review this one? Thanks :)




With regards,
Pavel Skripkin