Re: imx8mm board crash in drivers/usb/chipidea/ci_hdrc_imx.c

[Heiko Thiery]

Hi Fabio,

Am So., 19. Sept. 2021 um 15:08 Uhr schrieb Fabio Estevam <festevam@xxxxxxxxx>:
>
> Hi Heiko,
>
> On Sun, Sep 19, 2021 at 7:10 AM Heiko Thiery <heiko.thiery@xxxxxxxxx> wrote:
>
> > Meanwhile I figured out that in ci_hdrc_imx_probe() the "fsl,usbphy"
> > node is not found [1]. But I do not understand why.
> >
> > The following failure leads to the return code of -19 (ENODEV) and
> > sets the pyh to NULL:
> > "failed to get fsl,usbphy phandle in /soc@0/bus@32c00000/usb@32e40000 node"
>
> Since commit:
> commit 78e80c4b4238c1f5642b975859664fced4f9c69e
> Author: Marek Vasut <marex@xxxxxxx>
> Date:   Wed Jul 21 18:39:55 2021 +0200
>
>     arm64: dts: imx8m: Replace deprecated fsl,usbphy DT props with phys
>
>     The fsl,usbphy DT property is deprecated, replace it with phys DT
>     property and specify #phy-cells. No functional change.
>
>     Signed-off-by: Marek Vasut <marex@xxxxxxx>
>     Cc: Fabio Estevam <festevam@xxxxxxxxx>
>     Cc: NXP Linux Team <linux-imx@xxxxxxx>
>     Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
>     To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>     Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>
>
> Don't we need to search for 'phys' too?
>
> Does this patch help?
> https://pastebin.com/raw/yZKz1huL

I can confirm that on the next-20210915 (that includes commit
78e80c4b4238c1f5642b975859664fced4f9c69e) your provided patch solves
the problem.

But is it explainable that in the version before the commit
78e80c4b4238c1f5642b975859664fced4f9c69e the problem occurs in the
form I reported?

-- 
Heiko