Re: [PATCH 2/4] x86/mce: Get rid of machine_check_vector

From: Luck, Tony
Date: Mon Sep 20 2021 - 00:58:44 EST


On Fri, Sep 17, 2021 at 12:53:53PM +0200, Borislav Petkov wrote:
> @@ -126,7 +123,9 @@ struct mca_config {
> ser : 1,
> recovery : 1,
> bios_cmci_threshold : 1,
> - __reserved : 59;
> + /* Proper #MC exception handler is set */
> + initialized : 1,
> + __reserved : 58;

Does this __reserved field do anything useful? It seems to
just be an annoyance that must be updated each time a new
bit is added. Surely the compiler will see that these bitfields
are in a "u64" and do the math and skip to the right boundary
without this.

-Tony