Re: [PATCH net v5 1/2] net: netfilter: Limit the number of ftp helper port attempts

From: Florian Westphal
Date: Mon Sep 20 2021 - 03:22:49 EST


Cole Dishington <Cole.Dishington@xxxxxxxxxxxxxxxxxxx> wrote:
> In preparation of fixing the port selection of ftp helper when using
> NF_NAT_RANGE_PROTO_SPECIFIED, limit the number of ftp helper port
> attempts to 128.
>
> Looping a large port range takes too long. Instead select a random
> offset within [ntohs(exp->saved_proto.tcp.port), 65535] and try 128
> ports.

LGTM, please fix the format argument error the kbuild robot reported
and resend. You may add

Acked-by: Florian Westphal <fw@xxxxxxxxx>

when doing so.