Re: [PATCH] staging: r8188eu: fix -Wrestrict warnings

[Greg Kroah-Hartman]

On Mon, Sep 20, 2021 at 11:55:09AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Adding back the nonstandard ioctl commands caused -Wrestrict warnings
> when building with 'make W=1':
> 
> drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_mp_read_rf':
> drivers/staging/r8188eu/os_dep/ioctl_linux.c:5515:27: error: 'sprintf' argument 3 overlaps destination object 'extra' [-Werror=restrict]
>  5515 |                           sprintf(extra, "%s %d", extra, strtou);
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/r8188eu/os_dep/ioctl_linux.c:5470:54: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
>  5470 |                         struct iw_point *wrqu, char *extra)
>       |                                                ~~~~~~^~~~~
> 
> Change these to the same construct used elsewhere in that driver,
> with an offset to the string to make the warning go away.
> 
> The ioctl commands were previously removed, and it's unlikely that
> anything is actually using them, so ideally I would prefer to have
> them removed again.

I'll apply this to get rid of the warning, but will also work on
removing the ioctls entirely.

thanks,

greg k-h