Re: [PATCH 3/3] firmware: arm_scmi: Add proper barriers to scmi virtio device

From: Sudeep Holla
Date: Mon Sep 20 2021 - 07:09:59 EST


Hi Michael,

On Thu, Sep 16, 2021 at 11:33:36AM +0100, Cristian Marussi wrote:
> Only one single SCMI Virtio device is currently supported by this driver
> and it is referenced using a static global variable which is initialized
> once for all during probing and nullified at virtio device removal.
>
> Add proper SMP barriers to protect accesses to such device reference to
> ensure that the initialzation state of such device is correctly observed by
> all PEs at any time.
>
> Return -EBUSY, instead of -EINVAL, and a descriptive error message if more
> than one SCMI Virtio device is ever found and probed.
>

I was thinking of applying this patch and probably 2/3 as fix for v5.15.
Let me know if you have any objections.

--
Regards,
Sudeep