Re: [PATCH v8 07/19] staging: r8188eu: remove unnecessary comment in usbctrl_vendorreq()

From: Greg Kroah-Hartman
Date: Mon Sep 20 2021 - 07:49:11 EST


On Mon, Sep 20, 2021 at 01:53:44AM +0200, Fabio M. De Francesco wrote:
> Remove an unnecessary comment in usbctrl_vendorreq().
>
> Co-developed-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> ---
> drivers/staging/r8188eu/hal/usb_ops_linux.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> index a52aeb2558ad..fc3da0fbf474 100644
> --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> @@ -73,7 +73,6 @@ static int usbctrl_vendorreq(struct intf_hdl *intfhdl, u16 value, void *data, u1
> /* status != len && status >= 0 */
> if (status > 0) {
> if (requesttype == REALTEK_USB_VENQT_READ) {
> - /* For Control read transfer, we have to copy the read data from io_buf to data. */
> memcpy(data, io_buf, len);
> }

And now you have a coding style issue :(

Don't try to fix up one and add another one please.

thanks,

greg k-h