Re: [PATCH v8 15/19] staging: r8188eu: change the type of a variable in rtw_read16()

From: Dan Carpenter
Date: Mon Sep 20 2021 - 07:57:29 EST


On Mon, Sep 20, 2021 at 01:53:52AM +0200, Fabio M. De Francesco wrote:
> Change the type of "data" from __le32 to __le16.
>

You should note in the commit message that:

The last two bytes of "data" are not initialized so the le32_to_cpu(data)
technically reads uninitialized data. This can likely be detected by
the KASan checker as reading uninitialized data. But because the bytes
are discarded in the end so this will not affect runtime.

regards,
dan carpenter