Re: [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo()

From: Aswath Govindraju
Date: Mon Sep 20 2021 - 08:36:50 EST


Hi all,

On 16/09/21 4:51 pm, Aswath Govindraju wrote:
> The write into fifo must be performed with an offset from the message ram
> base address. Therefore, fix the base address to mram_base.
>
> Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors")
> Signed-off-by: Aswath Govindraju <a-govindraju@xxxxxx>
> ---

This change along with some more fixes are squashed and posted in,

https://patchwork.kernel.org/project/netdevbpf/patch/20210920123344.2320-1-a-govindraju@xxxxxx/

Thanks,
Aswath

> drivers/net/can/m_can/m_can_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> index 308d4f2fff00..08eac03ebf2a 100644
> --- a/drivers/net/can/m_can/m_can_platform.c
> +++ b/drivers/net/can/m_can/m_can_platform.c
> @@ -52,7 +52,7 @@ static int iomap_write_fifo(struct m_can_classdev *cdev, int offset,
> {
> struct m_can_plat_priv *priv = cdev_to_priv(cdev);
>
> - iowrite32_rep(priv->base + offset, val, val_count);
> + iowrite32_rep(priv->mram_base + offset, val, val_count);
>
> return 0;
> }
>