Re: [PATCH] pinctrl-intel: Fix NULL pointer dereference

From: Andy Shevchenko
Date: Mon Sep 20 2021 - 12:03:02 EST


On Mon, Sep 20, 2021 at 4:00 PM <zboszor@xxxxx> wrote:
> On an Elkhart Lake based POS hardware prototype, I got this Oops:

Thank you for the report, my comments below.

> [ 1.587455] BUG: kernel NULL pointer dereference, address: 0000000000000000

First of all, do not spoil the commit message with unneeded lines of
the traceback. Only ~4-5 is usually more than enough.

> It's probably a firmware bug, so be overly protective:

Patch is simply wrong. While Oops will be gone, the driver won't work correctly.
Yes, it's either a firmware bug or the driver is outdated (depends
from which side you look at this issue).

I have heard that new firmware is on its way to the customers, but I
have no more information right now.

--
With Best Regards,
Andy Shevchenko