Re: [PATCH 00/11] fs/ntfs3: Refactor fill_super
From: Konstantin Komarov
Date: Mon Sep 20 2021 - 12:07:49 EST
On 09.09.2021 21:09, Kari Argillander wrote:
> Two first ones are only ones that fix something. Everything else
> just take off dead code or make it little bit cleaner. They should
> be pretty trivial.
>
> As promise to Christian, 10/11 makes one section cleaner as he
> wanted [1].
>
> [1]: lore.kernel.org/ntfs3/20210824113217.ncuwc3zs452mdgec@wittgenstein
>
> Kari Argillander (11):
> fs/ntfs3: Fix wrong error message $Logfile -> $UpCase
> fs/ntfs3: Change EINVAL to ENOMEM when d_make_root fails
> fs/ntfs3: Remove impossible fault condition in fill_super
> fs/ntfs3: Return straight without goto in fill_super
> fs/ntfs3: Remove unnecessary variable loading in fill_super
> fs/ntfs3: Use sb instead of sbi->sb in fill_super
> fs/ntfs3: Remove tmp var is_ro in ntfs_fill_super
> fs/ntfs3: Remove tmp pointer bd_inode in fill_super
> fs/ntfs3: Remove tmp pointer upcase in fill_super
> fs/ntfs3: Initialize pointer before use place in fill_super
> fs/ntfs3: Initiliaze sb blocksize only in one place + refactor
>
> fs/ntfs3/super.c | 121 +++++++++++++----------------------------------
> 1 file changed, 33 insertions(+), 88 deletions(-)
>
>
> base-commit: 15b2ae776044ac52cddda8a3e6c9fecd15226b8c
>
Thanks for work - applied!