[PATCH] gfs2: Fix unused value warning in do_gfs2_set_flags()

From: Tim Gardner
Date: Mon Sep 20 2021 - 15:07:42 EST


Coverity complains of an unused value:

CID 119623 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value -1 to error here, but that stored value is
overwritten before it can be used.
237 error = -EPERM;

Fix it by removing the assignment.

Cc: Bob Peterson <rpeterso@xxxxxxxxxx>
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Cc: cluster-devel@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
---
fs/gfs2/file.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 354cf85154a6..7e09d2168030 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -234,7 +234,6 @@ static int do_gfs2_set_flags(struct inode *inode, u32 reqflags, u32 mask)
if ((new_flags ^ flags) == 0)
goto out;

- error = -EPERM;
if (!IS_IMMUTABLE(inode)) {
error = gfs2_permission(&init_user_ns, inode, MAY_WRITE);
if (error)
--
2.33.0