Re: [PATCH] tcp: tcp_drop adds `SNMP` and `reason` parameter for tracing

[Cong Wang]

On Mon, Sep 20, 2021 at 10:15 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Mon, 20 Sep 2021 09:54:02 -0700
> Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote:
>
> > Also, kernel does not have to explain it in strings, those SNMP
> > counters are already available for user-space, so kernel could
> > just use SNMP enums and let user-space interpret them. In many
> > cases, you are just adding strings for those SNMP enums.
>
> The strings were requested by the networking maintainers.
>
>   https://lore.kernel.org/all/CANn89iJO8jzjFWvJ610TPmKDE8WKi8ojTr_HWXLz5g=4pdQHEA@xxxxxxxxxxxxxx/

I think you misunderstand my point. Eric's point is hex address
vs. string, which I never disagree. With SNMP enum, user-space
can easily interpret it to string too, so at the end you still get strings
but not from kernel. This would at least save a handful of strings
from vmlinux, especially if we expand it beyond TCP.

Thanks.