Re: [tip: sched/core] sched: Make struct sched_statistics independent of fair sched class

[Dan Carpenter]

On Thu, Sep 16, 2021 at 11:59:30AM -0000, tip-bot2 for Yafang Shao wrote:
> @@ -11424,7 +11441,7 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
>  		if (!cfs_rq)
>  			goto err;
>  
> -		se = kzalloc_node(sizeof(struct sched_entity),
> +		se = kzalloc_node(sizeof(struct sched_entity_stats),

This wasn't there in the original patch and it causes a Smatch warning
because "se" is declared as a "sched_entity" but it's allocating a
larger "sched_entity_stats" which contains a sched_entity.

To me, ideally, we would update the type of se.

>  				  GFP_KERNEL, cpu_to_node(i));
>  		if (!se)
>  			goto err_free_rq;

regards,
dan carpenter