Re: [PATCH 2/7] ASoC: qcom: dt-bindings: Add compatible names for lpass sc7280 digital codecs

From: Srinivasa Rao Mandadapu
Date: Tue Sep 21 2021 - 02:59:29 EST



On 9/20/2021 6:54 PM, Srinivas Kandagatla wrote:
Thanks for your time Srini!!

On 20/09/2021 08:35, Srinivasa Rao Mandadapu wrote:
Update compatible names in va, wsa, rx and tx macro codes for lpass sc7280

Signed-off-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx>
---
Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 4 +++-
Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml | 4 +++-
Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 4 +++-
Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml | 4 +++-
  4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
index 443d556..a4e767e 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
@@ -11,7 +11,9 @@ maintainers:
    properties:
    compatible:
-    const: qcom,sm8250-lpass-rx-macro
+    oneOf:
+      - const: qcom,sm8250-lpass-rx-macro
+      - const: qcom,sc7280-lpass-rx-macro
Recently Rob did tree wide change to use enum instead of oneOf for below reason
"
'enum' is equivalent to 'oneOf' with a list of 'const' entries, but 'enum' is more concise and yields better error messages."

So, can you move these to enums like:

enum:
  - qcom,sm8250-lpass-rx-macro
  - qcom,sc7280-lpass-rx-macro

--srini
Okay. will change accordingly and post it.

    reg:
      maxItems: 1
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
index 6b5ca02..cdec478 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
@@ -11,7 +11,9 @@ maintainers:
    properties:
    compatible:
-    const: qcom,sm8250-lpass-tx-macro
+    oneOf:
+      - const: qcom,sm8250-lpass-tx-macro
+      - const: qcom,sc7280-lpass-tx-macro
      reg:
      maxItems: 1
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
index 679b49c..e15bc05 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -11,7 +11,9 @@ maintainers:
    properties:
    compatible:
-    const: qcom,sm8250-lpass-va-macro
+    oneOf:
+      - const: qcom,sm8250-lpass-va-macro
+      - const: qcom,sc7280-lpass-va-macro
      reg:
      maxItems: 1
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
index 435b019..2dcccb5 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
@@ -11,7 +11,9 @@ maintainers:
    properties:
    compatible:
-    const: qcom,sm8250-lpass-wsa-macro
+    oneOf:
+      - const: qcom,sm8250-lpass-wsa-macro
+      - const: qcom,sc7280-lpass-wsa-macro
      reg:
      maxItems: 1

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.