Re: [PATCH V1 3/3] dt-bindings: tegra: clock,memory,thermal: add header Copyright

[Krzysztof Kozlowski]

On 21/09/2021 11:42, Bitan Biswas wrote:
> Add Copyright for below Tegra dt-bindings headers:
> 1. clock
> 2. gpio
> 3. mailbox
> 4. memory
> 5. thermal
> 6. reset
> 7. pinctrl

Why? Please explain.

These are trivial constants, so I doubt there is here any copyright value.

> 
> Signed-off-by: Bitan Biswas <bbiswas@xxxxxxxxxx>
> ---
>  include/dt-bindings/clock/tegra114-car.h            | 4 ++++
>  include/dt-bindings/clock/tegra124-car-common.h     | 4 ++++
>  include/dt-bindings/clock/tegra124-car.h            | 4 ++++
>  include/dt-bindings/clock/tegra186-clock.h          | 6 ++++++
>  include/dt-bindings/clock/tegra20-car.h             | 4 ++++
>  include/dt-bindings/clock/tegra210-car.h            | 4 ++++
>  include/dt-bindings/clock/tegra30-car.h             | 4 ++++
>  include/dt-bindings/gpio/tegra-gpio.h               | 4 ++++
>  include/dt-bindings/gpio/tegra186-gpio.h            | 4 ++++
>  include/dt-bindings/mailbox/tegra186-hsp.h          | 4 ++++
>  include/dt-bindings/memory/tegra114-mc.h            | 6 ++++++
>  include/dt-bindings/memory/tegra124-mc.h            | 6 ++++++
>  include/dt-bindings/memory/tegra186-mc.h            | 6 ++++++
>  include/dt-bindings/memory/tegra194-mc.h            | 6 ++++++
>  include/dt-bindings/memory/tegra210-mc.h            | 6 ++++++
>  include/dt-bindings/memory/tegra30-mc.h             | 6 ++++++
>  include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h    | 6 ++++++
>  include/dt-bindings/reset/tegra124-car.h            | 4 ++++
>  include/dt-bindings/reset/tegra210-car.h            | 4 ++++
>  include/dt-bindings/thermal/tegra124-soctherm.h     | 4 ++++
>  include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 4 ++++
>  include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 4 ++++
>  22 files changed, 104 insertions(+)
> 

(...)

> @@ -1,5 +1,9 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  /*
> + * Copyright (c) 2016-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Joseph Lo <josephl@xxxxxxxxxx>
> + *
>   * This header provides constants for binding nvidia,tegra186-hsp.
>   */
>  
> diff --git a/include/dt-bindings/memory/tegra114-mc.h b/include/dt-bindings/memory/tegra114-mc.h
> index dfe99c8a5ba5..1a2d16853847 100644
> --- a/include/dt-bindings/memory/tegra114-mc.h
> +++ b/include/dt-bindings/memory/tegra114-mc.h
> @@ -1,4 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <treding@xxxxxxxxxx>
> + *
> + */
>  #ifndef DT_BINDINGS_MEMORY_TEGRA114_MC_H
>  #define DT_BINDINGS_MEMORY_TEGRA114_MC_H
>  
> diff --git a/include/dt-bindings/memory/tegra124-mc.h b/include/dt-bindings/memory/tegra124-mc.h
> index 7e73bb400eca..8a7abf2325b6 100644
> --- a/include/dt-bindings/memory/tegra124-mc.h
> +++ b/include/dt-bindings/memory/tegra124-mc.h
> @@ -1,4 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <treding@xxxxxxxxxx>
> + *
> + */
>  #ifndef DT_BINDINGS_MEMORY_TEGRA124_MC_H
>  #define DT_BINDINGS_MEMORY_TEGRA124_MC_H
>  
> diff --git a/include/dt-bindings/memory/tegra186-mc.h b/include/dt-bindings/memory/tegra186-mc.h
> index be313d3790ae..283ea29bf426 100644
> --- a/include/dt-bindings/memory/tegra186-mc.h
> +++ b/include/dt-bindings/memory/tegra186-mc.h
> @@ -1,4 +1,10 @@
>  /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2017-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <treding@xxxxxxxxxx>
> + *
> + */
>  #ifndef DT_BINDINGS_MEMORY_TEGRA186_MC_H
>  #define DT_BINDINGS_MEMORY_TEGRA186_MC_H
>  
> diff --git a/include/dt-bindings/memory/tegra194-mc.h b/include/dt-bindings/memory/tegra194-mc.h
> index 16bb62bf8166..30182fd94f0f 100644
> --- a/include/dt-bindings/memory/tegra194-mc.h
> +++ b/include/dt-bindings/memory/tegra194-mc.h
> @@ -1,4 +1,10 @@
>  /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2020-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <treding@xxxxxxxxxx>
> + *
> + */
>  #ifndef DT_BINDINGS_MEMORY_TEGRA194_MC_H
>  #define DT_BINDINGS_MEMORY_TEGRA194_MC_H
>  
> diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h
> index 5e082547f179..c4e3ba88f77b 100644
> --- a/include/dt-bindings/memory/tegra210-mc.h
> +++ b/include/dt-bindings/memory/tegra210-mc.h
> @@ -1,4 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2015-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <treding@xxxxxxxxxx>
> + *
> + */
>  #ifndef DT_BINDINGS_MEMORY_TEGRA210_MC_H
>  #define DT_BINDINGS_MEMORY_TEGRA210_MC_H
>  
> diff --git a/include/dt-bindings/memory/tegra30-mc.h b/include/dt-bindings/memory/tegra30-mc.h
> index 930f708aca17..4972cf7e3cf2 100644
> --- a/include/dt-bindings/memory/tegra30-mc.h
> +++ b/include/dt-bindings/memory/tegra30-mc.h
> @@ -1,4 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <treding@xxxxxxxxxx>
> + *

I am sorry, but that's not entirely how it works. You cannot add only
selected (stripped) copyrights backwards. If adding, please include all
copyright holders.


Best regards,
Krzysztof