Re: [PATCH] [PATCH v2] misc: fastrpc: fix improper packet size calculation

[Greg KH]

On Tue, Sep 21, 2021 at 05:05:29PM +0530, jeyr@xxxxxxxxxxxxxx wrote:
> On 2021-09-21 17:02, Greg KH wrote:
> > On Tue, Sep 21, 2021 at 04:27:27PM +0530, Jeya R wrote:
> > > The buffer list is sorted and this is not being considered while
> > > calculating packet size. This would lead to improper copy length
> > > calculation for non-dmaheap buffers which would eventually cause
> > > sending improper buffers to DSP.
> > > 
> > > Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke
> > > method")
> > > Signed-off-by: Jeya R <jeyr@xxxxxxxxxxxxxx>
> > > 
> > > Changes in v2:
> > > - updated commit message to proper format
> > > - added fixes tag to commit message
> > > - removed unnecessary variable initialization
> > > - removed length check during payload calculation
> > > ---
> > >  drivers/misc/fastrpc.c | 10 ++++++----
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> > The "Changes" need to go below the --- line, as the documentation states
> > to do.
> > 
> > thanks,
> > 
> > greg k-h
> Thanks Greg for your comment. Will resend PATCH 2 to address this.

v3 please.