Re: [RESEND PATCH v2] misc: fastrpc: fix improper packet size calculation

From: Greg KH
Date: Tue Sep 21 2021 - 07:50:19 EST


On Tue, Sep 21, 2021 at 05:03:01PM +0530, Jeya R wrote:
> The buffer list is sorted and this is not being considered while
> calculating packet size. This would lead to improper copy length
> calculation for non-dmaheap buffers which would eventually cause
> sending improper buffers to DSP.
>
> Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method")
> Signed-off-by: Jeya R <jeyr@xxxxxxxxxxxxxx>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>
> Changes in v2:
> - updated commit message to proper format
> - added fixes tag to commit message
> - removed unnecessary variable initialization
> - removed length check during payload calculation
> ---
> drivers/misc/fastrpc.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)

Again, please read the documentation, changes go below the --- line.

I am _SURE_ there is a guide somewhere at your employer for how to do
all of this properly, right?

thanks,

greg k-h