Re: [PATCH 2/2] mm: Move fold_vm_numa_events() to fix NUMA without SMP
From: Mel Gorman
Date: Tue Sep 21 2021 - 08:33:30 EST
On Thu, Sep 16, 2021 at 10:42:43AM +0200, Geert Uytterhoeven wrote:
> If CONFIG_NUMA=y, but CONFIG_SMP=n (e.g. sh/migor_defconfig):
>
> sh4-linux-gnu-ld: mm/vmstat.o: in function `vmstat_start':
> vmstat.c:(.text+0x97c): undefined reference to `fold_vm_numa_events'
> sh4-linux-gnu-ld: drivers/base/node.o: in function `node_read_vmstat':
> node.c:(.text+0x140): undefined reference to `fold_vm_numa_events'
> sh4-linux-gnu-ld: drivers/base/node.o: in function `node_read_numastat':
> node.c:(.text+0x1d0): undefined reference to `fold_vm_numa_events'
>
> Fix this by moving fold_vm_numa_events() outside the SMP-only section.
>
> Fixes: f19298b9516c1a03 ("mm/vmstat: convert NUMA statistics to basic NUMA counters")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Acked-by: Mel Gorman <mgorman@xxxxxxx>
--
Mel Gorman
SUSE Labs