Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries

[Rafael J. Wysocki]

On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi,
>
> On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> > BRI0A49 and BDP3336 are already on the list.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
> driver. I'll leave picking this one up to you.

I'll pick it up, thanks!


> > ---
> >  drivers/acpi/acpi_pnp.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > index 8f2dc176bb41..ffdcfcd4a10d 100644
> > --- a/drivers/acpi/acpi_pnp.c
> > +++ b/drivers/acpi/acpi_pnp.c
> > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> >       {"BRI0A49"},            /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> >       {"BRI1400"},            /* Boca Research 33,600 ACF Modem */
> >       {"BRI3400"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > -     {"BRI0A49"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > -     {"BDP3336"},            /* Best Data Products Inc. Smart One 336F PnP Modem */
> >       {"CPI4050"},            /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> >       {"CTL3001"},            /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> >       {"CTL3011"},            /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
> >
>