Re: [PATCH 5.10 116/122] bnxt_en: Convert to use netif_level() helpers.

From: Joe Perches
Date: Tue Sep 21 2021 - 12:05:26 EST


On Tue, 2021-09-21 at 17:53 +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 21, 2021 at 08:49:52AM -0700, Joe Perches wrote:
> > On Tue, 2021-09-21 at 17:04 +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Sep 21, 2021 at 07:30:42AM -0700, Joe Perches wrote:
> > > > On Mon, 2021-09-20 at 18:44 +0200, Greg Kroah-Hartman wrote:
> > > > > From: Michael Chan <michael.chan@xxxxxxxxxxxx>
> > > > >
> > > > > [ Upstream commit 871127e6ab0d6abb904cec81fc022baf6953be1f ]
> > > > >
> > > > > Use the various netif_level() helpers to simplify the C code. This was
> > > > > suggested by Joe Perches.
> > > >
> > > > There isn't an actual change here.
> > > >
> > > > Unless this is a precursor to another patch, this isn't anything
> > > > that should go into stable.
> > > >
> > > It is a dependancy for other fixes.
> >
> > Then it's useful/necessary to mark it as such when applying it.
> >
>
> That's hard/difficult/messy to do :)

Smiley faces don't make the work you do any easier.

Nor better.

You are specifically pulling dependencies.
It doesn't seem particularly difficult to script.