Re: [PATCH V9 1/8] dt-bindings: spi: Add sc7280 support
From: Stephen Boyd
Date: Tue Sep 21 2021 - 14:11:26 EST
Quoting Rajesh Patil (2021-09-21 03:38:59)
> Add compatible for sc7280 SoC.
>
> Signed-off-by: Rajesh Patil <rajpat@xxxxxxxxxxxxxx>
> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> ---
One nit below
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> index ef5698f..1c8b2ea 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> @@ -21,7 +21,10 @@ allOf:
> properties:
> compatible:
> items:
> - - const: qcom,sdm845-qspi
> + - enum:
> + - qcom,sdm845-qspi
> + - qcom,sc7280-qspi
Would be nice to keep this alphabet sorted too.
> +
> - const: qcom,qspi-v1
>
> reg: