RE: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc functionality

From: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Date: Tue Sep 21 2021 - 20:33:42 EST




> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Tuesday, September 21, 2021 11:21 PM
> To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
> <longpeng2@xxxxxxxxxx>
> Cc: andraprs@xxxxxxxxxx; lexnv@xxxxxxxxxx; alcioa@xxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Gonglei (Arei) <arei.gonglei@xxxxxxxxxx>;
> kamal@xxxxxxxxxxxxx; pbonzini@xxxxxxxxxx; sgarzare@xxxxxxxxxx;
> stefanha@xxxxxxxxxx; vkuznets@xxxxxxxxxx; ne-devel-upstream@xxxxxxxxxx
> Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc
> functionality
>
> On Tue, Sep 21, 2021 at 11:10:38PM +0800, Longpeng(Mike) wrote:
> > Add test framework for the misc functionality.
>
> What is "the misc functionality"?
>

The functionalities provided in the ne_misc_dev.c

> >
> > Signed-off-by: Longpeng(Mike) <longpeng2@xxxxxxxxxx>
> > ---
> > drivers/virt/nitro_enclaves/Kconfig | 8 ++++++++
> > drivers/virt/nitro_enclaves/ne_misc_dev.c | 27
> +++++++++++++++++++++++++++
> > drivers/virt/nitro_enclaves/ne_misc_test.c | 17 +++++++++++++++++
> > 3 files changed, 52 insertions(+)
> > create mode 100644 drivers/virt/nitro_enclaves/ne_misc_test.c
>
> What changed from v1?
>

The unit tests are new added in v2, described in the cover letter.

> thanks,
>
> greg k-h