Re: [PATCH V2] arm64/mm: Add pud_sect_supported()

[Itaru Kitayama]

How did you test the 16K page size configurations? In QEMU? I wasn't
aware of hardware that's capable 16KB page size.

On Wed, Sep 22, 2021 at 1:47 PM Anshuman Khandual
<anshuman.khandual@xxxxxxx> wrote:
>
>
>
> On 9/20/21 9:11 PM, Catalin Marinas wrote:
> > On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
> >> Section mapping at PUD level is supported only on 4K pages and currently it
> >> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
> >> new helper pud_sect_supported() for this purpose, which particularly cleans
> >> up the HugeTLB code path. It updates relevant switch statements with checks
> >> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
> >> identical switch case values in those code blocks.
> >>
> >> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> >> Cc: Will Deacon <will@xxxxxxxxxx>
> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Suggested-by: Mark Rutland <mark.rutland@xxxxxxx>
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> >
> > Assuming that you tested the corresponding configurations,
>
> Right, I did test this on all page size and VA bits configurations
> , including the specific ones which were problematic.
>
> >
> > Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel