Re: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages

From: Jarkko Sakkinen
Date: Wed Sep 22 2021 - 01:17:59 EST


On Tue, 2021-09-21 at 21:34 +0000, Luck, Tony wrote:
> > > Since there are multiple uses of the "owner" field with different types
> > > change the sgx_epc_page structure to define an anonymous union with
> > > each of the uses explicitly called out.
> >
> > But it's still always a pointer.
> >
> > And not only that, but two alternative fields in that union have *exactly* the
> > same type, so it's kind of artifically representing the problem more complex
> > than it really is.
>
> Bother! I seem to have jumbled some old bits of v4 into this series.
>
> I agree that we just want "void *owner; here. I even made the changes.
> Then managed to lose them while updating.
>
> I'll find the bits I lost and re-merge them in.
>
> -Tony

Yeah, ok, cool, thank you. Just reporting what I was observing :-)

/Jarkko