Re: [PATCH 2/6] mm/swap: Introduce alternative per-cpu LRU cache locking

From: Sebastian Andrzej Siewior
Date: Wed Sep 22 2021 - 05:20:51 EST


On 2021-09-22 10:47:07 [+0200], nsaenzju@xxxxxxxxxx wrote:
> > *why* use migrate_disable(), that's horrible!
>
> I was trying to be mindful of RT. They don't appreciate people taking spinlocks
> just after having disabled preemption.
>
> I think getting local_lock(&locks->local) is my only option then. But it adds
> an extra redundant spinlock in the RT+NOHZ_FULL case.

spin_lock() does not disable preemption on PREEMPT_RT. You don't
disables preemption on purpose or did I miss that?

Sebastian