Re: [PATCH v9 16/16] staging: r8188eu: remove usb_vendor_req_mutex

From: Pavel Skripkin
Date: Wed Sep 22 2021 - 09:21:19 EST


On 9/21/21 21:18, Fabio M. De Francesco wrote:
From: Pavel Skripkin <paskripkin@xxxxxxxxx>

This mutex was used to protect shared buffer for USB requests. Since
buffer was removed in previous patch we can remove this mutex as well.

Furthermore, because it was used to serialize the calls to the Core USB
API, we thoroughly tested the enabling of concurrent firing of USB requests
without the mutex and found no problems of any kind in common use cases.

Co-developed-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>

Hi, Greg!

If all is OK with previous 15 patches, please, do not take this one, it causes problems with connection... :)

I don't understand what went wrong after v8, but anyway, this one should not be applied for now, since it's broken


Thank you



With regards,
Pavel Skripkin