Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata
From: Lee Jones
Date: Wed Sep 22 2021 - 09:23:56 EST
On Thu, 02 Sep 2021, Mauro Carvalho Chehab wrote:
> There are lots of fields at struct hi6421_spmi_pmic that aren't
s/at/in/
> used. In a matter of fact, only regmap is needed.
s/In/As/
> So, drop the struct as a hole, and set just the regmap as
s/hole/whole/
s/set just/just set/
> the drvdata.
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> ---
> drivers/mfd/hi6421-spmi-pmic.c | 16 +++++----------
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
> drivers/misc/hi6421v600-irq.c | 9 ++++-----
> drivers/regulator/hi6421v600-regulator.c | 10 +++++-----
> include/linux/mfd/hi6421-spmi-pmic.h | 25 ------------------------
> 4 files changed, 14 insertions(+), 46 deletions(-)
> delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h
Looks as though we're still missing a misc Ack.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog