Re: [PATCH] mac80211_hwsim: enable 6GHz channels

From: Johannes Berg
Date: Wed Sep 22 2021 - 10:29:46 EST


On Wed, 2021-09-22 at 11:28 -0300, Ramon Fontes wrote:
> This adds 6 GHz capabilities and reject HT/VHT
>

It'd be nice to add a version to the subject, with -vN on the git-send-
email commandline :)

> + .he_6ghz_capa = {
> + .capa = IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START |
> + IEEE80211_HE_6GHZ_CAP_MAX_AMPDU_LEN_EXP |
> + IEEE80211_HE_6GHZ_CAP_MAX_MPDU_LEN |
> + cpu_to_le16(IEEE80211_HE_6GHZ_CAP_TX_ANTPAT_CONS |
> + IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS),

Seems that needs to be around the *entire* initializer, not just parts
thereof?

The indentation could also use some work :)

johannes