Re: [PATCH v3 2/2] clk: qcom: Add Global Clock Controller driver for QCM2290

[Rob Herring]

On Sun, Sep 19, 2021 at 10:33:08AM +0800, Shawn Guo wrote:
> Add Global Clock Controller (GCC) driver for QCM2290.  This is a porting
> of gcc-scuba driver from CAF msm-4.19, with GDSC support added on top.
> 
> Because the alpha_pll on the platform has a different register
> layout (offsets), its own clk_alpha_pll_regs_offset[] is used in the
> driver.
> 
> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> ---
>  drivers/clk/qcom/Kconfig                     |    7 +
>  drivers/clk/qcom/Makefile                    |    1 +
>  drivers/clk/qcom/gcc-qcm2290.c               | 3047 ++++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-qcm2290.h |  188 ++

Really this should be in the binding patch.

Acked-by: Rob Herring <robh@xxxxxxxxxx>

>  4 files changed, 3243 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-qcm2290.c
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-qcm2290.h