Re: [PATCH v2 2/2] arm64: dts: qcom: sm8250: Add Coresight support

[Suzuki K Poulose]

On 23/09/2021 10:24, Tao Zhang wrote:
> On Tue, Sep 21, 2021 at 05:35:37PM +0100, Suzuki K Poulose wrote:
> > Hi Tao
> >
> > Are there no sinks at all on this platform ? I had this question on the
> > previous series. How is CoreSight useful on this platform otherwise ?
> >
> > On 13/09/2021 07:40, Tao Zhang wrote:
> ETF/ETR are the sinks on this target. And I have added the ETF to this
> device tree file. Since the ETR needs SMMU support on this target and
> SMMU has not been supported for now. I will add the ETR to device tree
> later if the SMMU is ready for this platform.

Thanks. That is fine. Btw, these sort of additional information could be
added to the cover letter to give a better picture of what you are 
trying to do and why.

> > > Add the basic coresight components found on Qualcomm SM8250 Soc. The
> > > basic coresight components include ETF, ETMs,STM and the related
> > > funnels.
> > >
> > > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 442 ++++++++++++++++++++++-
> > >   1 file changed, 438 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > > index 8ac96f8e79d4..9c8f87d80afc 100644
> > > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > > @@ -222,11 +222,445 @@
> > >   		regulator-max-microvolt = <1800000>;
> > >   		regulator-always-on;
> > >   	};
> > > -};
> > > -&adsp {
> > > -	status = "okay";
> > > -	firmware-name = "qcom/sm8250/adsp.mbn";
> >
> > Unrelated change ? Please keep it separate from the CoreSight changes.
> >
> > Suzuki
> I combined this change and ETM pid change into one seies because the ETM
> pid change validation needs ETM support. If there is no ETM
> configuration in the device tree, ETM pid change can not be verified.
> Do you think it would be better to separate them? Do I need to resubmit
> to separate them into two separate patches?

No, I am asking about the lines removed above. i.e,

 -&adsp {
 -	status = "okay";
 -	firmware-name = "qcom/sm8250/adsp.mbn";

It doesn't seem to be added back in the patch. So that means, the DT
lost those lines, without any mention of that in the description of
the patch. Moreover, the lines do not look like they were anything to
do with CoreSight. This is why I mentioned they look like "unrelated".

Suzuki