Re: [PATCH v7 04/12] x86/cpufeatures: Add TDX Guest CPU feature

[Borislav Petkov]

On Thu, Sep 16, 2021 at 11:35:42AM -0700, Kuppuswamy Sathyanarayanan wrote:
> @@ -495,6 +496,8 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
>  
>  	copy_bootdata(__va(real_mode_data));
>  
> +	tdx_early_init();
> +

| Changes since v4:
|  * Moved tdx_early_init() below copy_bootdata() because of
|    cmdline and IDT dependencies.


What "cmdline and IDT dependencies"?

Without a comment explaining why that thing must be there in the boot
order, you're adding more to the already fragile house of cards.

Explain please.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette