RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c

From: Marciniszyn, Mike
Date: Thu Sep 23 2021 - 08:18:52 EST


> > >
> >
> > It doesn't look like that works in irqs, softirqs.
>
> Are you certain about it?
>
> That sysctl is supposed to control the output of %p, nothing more.
>

Actually I think is controls %pK.

The code here is what I was referring to.

/*
* kptr_restrict==1 cannot be used in IRQ context
* because its test for CAP_SYSLOG would be meaningless.
*/
if (in_irq() || in_serving_softirq() || in_nmi()) {
if (spec.field_width == -1)
spec.field_width = 2 * sizeof(ptr);
return error_string(buf, end, "pK-error", spec);
}

Mike