Re: [PATCH] arm64: dts: marvell: add Globalscale MOCHAbin

From: Robert Marko
Date: Thu Sep 23 2021 - 14:15:26 EST


On Thu, Sep 23, 2021 at 7:32 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > + /* 88E6141 Topaz switch */
> > + switch: switch@3 {
> > + compatible = "marvell,mv88e6085";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <3>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&cp0_switch_pins>;
> > + reset-gpios = <&cp0_gpio1 0 GPIO_ACTIVE_LOW>;
> > +
> > + interrupt-parent = <&cp0_gpio1>;
> > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>
> The switch interrupt is a level interrupt, not an edge interrupt.

Hi Andrew,
thanks for catching this.
The same is true for the PCA9554 as well.
Will fix that now in v3.

Regards,
Robert
>
> Andrew



--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@xxxxxxxxxx
Web: www.sartura.hr