Re: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC

[Fabio Estevam]

Hi Cai,

On Tue, Sep 21, 2021 at 2:29 AM Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:

> +error_iio_device_register:
> +       clk_disable_unprepare(adc->ipg_clk);
> +error_adc_ipg_clk_enable:
> +       clk_disable_unprepare(adc->clk);
> +error_adc_clk_enable:
> +       regulator_disable(adc->vref);

Please rename these labels to indicate the action that will be performed.

Something like this:

error_ipg_clk_disable:
       clk_disable_unprepare(adc->ipg_clk);
error_adc_clk_disable:
       clk_disable_unprepare(adc->clk);
error_regulator_disable:
       regulator_disable(adc->vref);