Re: [PATCH 2/6] dt-bindings: hwmon: ti,tmp102: add bindings and remove from trivial devices
From: Guenter Roeck
Date: Thu Sep 23 2021 - 21:54:23 EST
On Tue, Sep 21, 2021 at 12:28:28PM +0200, Krzysztof Kozlowski wrote:
> The TI TMP102 temperature sensor does not fit into trivial devices
> bindings due to additional properties. Add separate bindings for it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> .../devicetree/bindings/hwmon/ti,tmp102.yaml | 47 +++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 2 -
> 2 files changed, 47 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> new file mode 100644
> index 000000000000..d3eff4fac107
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TMP102 temperature sensor
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tmp102
> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@48 {
> + compatible = "ti,tmp102";
> + reg = <0x48>;
> + interrupt-parent = <&gpio7>;
> + interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> + #thermal-sensor-cells = <1>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index c9333fb81fdf..6ad0628741cf 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -317,8 +317,6 @@ properties:
> # I2C Touch-Screen Controller
> - ti,tsc2003
> # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> - - ti,tmp102
> - # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> - ti,tmp103
> # Thermometer with SPI interface
> - ti,tmp121