RE: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the pad modes of imx8 pcie phy

From: Richard Zhu
Date: Thu Sep 23 2021 - 22:08:52 EST



> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Thursday, September 23, 2021 10:44 PM
> To: Richard Zhu <hongxing.zhu@xxxxxxx>
> Cc: l.stach@xxxxxxxxxxxxxx; kishon@xxxxxx; vkoul@xxxxxxxxxx;
> galak@xxxxxxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx;
> linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the
> pad modes of imx8 pcie phy
>
> On Thu, Sep 23, 2021 at 12:56 AM Richard Zhu <hongxing.zhu@xxxxxxx>
> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@xxxxxxxxxx>
> > > Sent: Thursday, September 23, 2021 3:26 AM
> > > To: Richard Zhu <hongxing.zhu@xxxxxxx>
> > > Cc: l.stach@xxxxxxxxxxxxxx; kishon@xxxxxx; vkoul@xxxxxxxxxx;
> > > galak@xxxxxxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx;
> > > linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> > > Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add
> > > binding for the pad modes of imx8 pcie phy
> > >
> > > On Fri, Sep 17, 2021 at 10:31:00AM +0800, Richard Zhu wrote:
> > > > Add binding for reference clock PAD modes of the i.MX8 PCIe PHY.
> > > >
> > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> > > > ---
> > > > include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++
> > > > 1 file changed, 14 insertions(+)
> > > > create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h
> > > >
> > > > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h
> > > b/include/dt-bindings/phy/phy-imx8-pcie.h
> > > > new file mode 100644
> > > > index 000000000000..fe198a0cc12c
> > > > --- /dev/null
> > > > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h
> > > > @@ -0,0 +1,14 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > >
> > > Perhaps this should match the dts files license...
> > >
> > Hi Rob:
> > What's the means of the "dts files license"?
>
> You include this into .dts files and those are dual licensed. The licenses should
> match (or be compatible).
>
[Richard Zhu] Thanks a lot. I'm clear now.
Would change the license to "SPDX-License-Identifier: GPL-2.0+" to make it compatible later.

Best Regards
Richard Zhu
> > I'm not clear understand that.
> > I found that there are almost similar "/* SPDX-License-Identifier: GPL-2.0
> */" license contained in the files of the /include/dt-bindings/phy folder.
>
> Yes, licenses are a mess. But what other files in include/dt-bindings/phy have
> don't matter. Where you use this file is what matters.
>
> Rob