Re: [PATCH 5.4 00/50] 5.4.149-rc1 review

[Daniel Díaz]

Hello!

On 9/24/21 7:43 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.149 release.
> There are 50 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 26 Sep 2021 12:43:20 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.149-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Regressions detected.

While building mxs_defconfig for arm with GCC 8, 9, 10 and 11, the following error was encountered:

  /builds/linux/arch/arm/mach-mxs/mach-mxs.c:285:26: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier]
    285 | static const struct gpio const tx28_gpios[] __initconst = {
        |                          ^~~~~
  /builds/linux/drivers/pwm/pwm-mxs.c: In function 'mxs_pwm_probe':
  /builds/linux/drivers/pwm/pwm-mxs.c:164:24: error: implicit declaration of function 'dev_err_probe'; did you mean 'device_reprobe'? [-Werror=implicit-function-declaration]
    164 |                 return dev_err_probe(&pdev->dev, ret, "failed to reset PWM\n");
        |                        ^~~~~~~~~~~~~
        |                        device_reprobe
  cc1: some warnings being treated as errors
  make[3]: *** [/builds/linux/scripts/Makefile.build:280: drivers/pwm/pwm-mxs.o] Error 1

The same problem is seen withs Clang 10, 11, 12, 13 and nightly:

  /builds/linux/drivers/pwm/pwm-mxs.c:156:10: error: implicit declaration of function 'dev_err_probe' [-Werror,-Wimplicit-function-declaration]
                  return dev_err_probe(&pdev->dev, ret, "failed to reset PWM\n");
                         ^
  /builds/linux/drivers/pwm/pwm-mxs.c:156:10: note: did you mean 'device_reprobe'?
  /builds/linux/include/linux/device.h:1565:25: note: 'device_reprobe' declared here
  extern int __must_check device_reprobe(struct device *dev);
                          ^
  1 error generated.
  make[3]: *** [/builds/linux/scripts/Makefile.build:262: drivers/pwm/pwm-mxs.o] Error 1

This is also seen in other branches (from 4.4 to 5.4). To reproduce this build locally:

  tuxmake \
    --target-arch=arm \
    --kconfig=mxs_defconfig \
    --toolchain=gcc-11 \
    --runtime=podman \
    config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers

or:

  tuxmake \
    --target-arch=arm \
    --kconfig=mxs_defconfig \
    --toolchain=clang-13 \
    --runtime=podman \
    config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers

Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx