Re: [PATCH] serial: 8250: allow disabling of Freescale 16550 compile test

From: Geert Uytterhoeven
Date: Fri Sep 24 2021 - 11:14:53 EST

On Fri, Sep 24, 2021 at 4:13 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
> The SERIAL_8250_FSL option is used to enable a workaround for a
> break-detection erratum for Freescale 16550 UARTs in the 8250 driver and
> is currently also used to enable support for ACPI enumeration.
> It is enabled on PPC, ARM and ARM64 whenever 8250 console support is
> enabled (since the quirk is needed for sysrq handling).
> Commit b1442c55ce89 ("serial: 8250: extend compile-test coverage")
> enabled compile testing of the code in question but did not provide a
> means to disable the option when COMPILE_TEST is enabled.
> Add a conditional input prompt instead so that SERIAL_8250_FSL is no
> longer enabled by default when compile testing while continuing to
> always enable the quirk for platforms that may need it.
> Fixes: b1442c55ce89 ("serial: 8250: extend compile-test coverage")
> Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds