Re: [PATCH] ACPI: APEI: Check NULL argument in exported symbol

From: Vasyl Gomonovych
Date: Fri Sep 24 2021 - 11:25:32 EST

> Looking at this more, that apei_hest_parse() thng should be made static and the export dropped.
I found apei_hest_parse() useful API to access the HEST table.
I think RAS development should increase the number of users of apei_hest_parse().
With this API we can read HEST and modify it.
Read example is to get a count of errors sources from HEST tables from the external driver and use that counter for driver data allocation.
One of write example is to patch error_status_address, if firmware change
memory layout based on boot conditions, error_status_address from hest.asl can require shift which can be recognized by driver.
Currently my RAS development underway and I recognize that legal and open way to touch HEST table is
via apei_hest_parse() from external driver.
Abstraction layer between driver main purposes and setup procedure HEST access utilize mainly apei_hest_parse().
From this perspective apei_hest_parse() become central function in access abstraction.
That is why I thought to make this check. But of course user should be responsible for own way of access.