Re: [PATCH v3 0/2] irqchip/mchp-eic: add driver for Microchip EIC

[Claudiu.Beznea]

Sorry, this had to be v4. I'll fix the versioning and re-post.

Thank you,
Claudiu Beznea

On 24.09.2021 19:28, Claudiu Beznea wrote:
> Hi,
> 
> This series adds support for Microchip External Interrupt Controller
> present on SAMA7G5. The controller supports for 2 external interrupt
> lines and is connected to GIC as follows:
> 
> pinX   +------+ EXT_IRQ0 +------+ int 153 (for pinX) +------+
> ------>|      |--------->|      |------------------->|      |
> pinY   | PIO  | EXT_IRQ1 | EIC  | int 154 (for pinY) | GIC  |
> ------>|      |--------->|      |------------------->|      |
>        +------+          +------+                    +------+
> 
> where PIO is the pin controller.
> 
> Thank you,
> Claudiu Beznea
> 
> Changes in v3:
> - use irq_domain_translate_twocell() instead of mchp_eic_domain_translate()
>   from v2
> - use IRQCHIP_PLATFORM_DRIVER_BEGIN(), IRQCHIP_MATCH(),
>   IRQCHIP_PLATFORM_DRIVER_END() instead of builtin_platform_driver()
> - register suspend/resume functins via syscore_ops; along with this
>   driver private data structure (of type struct mchp_eic has been declared
>   as static: struct mchp_eic *eic;)
> - collected tags
> 
> Changes in v2:
> - fix compilation warning on bindings
> 
> Changes in v2:
> - s/mchp/microchip in bindings
> - get rid of glitch filter settings
> - use s/eic@/interrupt-controller@ in bindings
> - removed '' around interrupts in bindings as proposed by Rob
> - removed glitch filter settings
> - switched to hierarchical irqchip driver
> - addressed review comments
> - use builtin_platform_driver instead of module_platform_driver
> 
> Claudiu Beznea (2):
>   dt-bindings: microchip,eic: add bindings
>   irqchip/mchp-eic: add support
> 
>  .../interrupt-controller/microchip,eic.yaml   |  73 +++++
>  MAINTAINERS                                   |   6 +
>  drivers/irqchip/Kconfig                       |   8 +
>  drivers/irqchip/Makefile                      |   1 +
>  drivers/irqchip/irq-mchp-eic.c                | 280 ++++++++++++++++++
>  5 files changed, 368 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/microchip,eic.yaml
>  create mode 100644 drivers/irqchip/irq-mchp-eic.c
>