Re: [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning

[Sasha Levin]

On Fri, Sep 24, 2021 at 09:11:18AM -0700, Florian Fainelli wrote:
> On 9/24/21 8:27 AM, Alexander Sverdlin wrote:
> > Hi Sasha,
> >
> > On 24/09/2021 13:52, Sasha Levin wrote:
> > > > > This patch series is present in v5.14 and fixes warnings seen at insmod
> > > > > with FTRACE and MODULE_PLTS enabled on ARM/Linux.
> > > >
> > > > All now queued up, thanks.
> > >
> > > Looks like 4.19 and older break the build:
> > >
> > > arch/arm/kernel/ftrace.c: In function 'ftrace_update_ftrace_func':
> > > arch/arm/kernel/ftrace.c:157:9: error: too few arguments to function 'ftrace_call_replace'
> > >   157 |   new = ftrace_call_replace(pc, (unsigned long)func);
> > >       |         ^~~~~~~~~~~~~~~~~~~
> >
> > in principle you can add ", true" as a third argument in all these ftrace_call_replace()
> > call-sites which still have two args.
>
> Sasha, what configuration failed to build? I build tested with
> mutli_v7_defconfig which does enable FTRACE by default and then ensured
> that CONFIG_ARM_MODULE_PLTS was enabled. From there I will re-submit,
> sorry about that.

allmodconfig seemed to have hit that.

--
Thanks,
Sasha