Re: [PATCH 5.14 080/100] habanalabs: fix race between soft reset and heartbeat

[Greg Kroah-Hartman]

On Fri, Sep 24, 2021 at 02:44:29PM +0200, Greg Kroah-Hartman wrote:
> From: Koby Elbaz <kelbaz@xxxxxxxxx>
> 
> [ Upstream commit 8bb8b505761238be0d6a83dc41188867d65e5d4c ]
> 
> There is a scenario where an ongoing soft reset would race with an
> ongoing heartbeat routine, eventually causing heartbeat to fail and
> thus to escalate into a hard reset.
> 
> With this fix, soft-reset procedure will disable heartbeat CPU messages
> and flush the (ongoing) current one before continuing with reset code.
> 
> Signed-off-by: Koby Elbaz <kelbaz@xxxxxxxxx>
> Reviewed-by: Oded Gabbay <ogabbay@xxxxxxxxxx>
> Signed-off-by: Oded Gabbay <ogabbay@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  drivers/misc/habanalabs/common/device.c      | 53 +++++++++++++++-----
>  drivers/misc/habanalabs/common/firmware_if.c | 18 +++++--
>  drivers/misc/habanalabs/common/habanalabs.h  |  4 +-
>  drivers/misc/habanalabs/common/hw_queue.c    | 30 ++++-------
>  4 files changed, 67 insertions(+), 38 deletions(-)
> 

This change adds a build warning so I'm going to drop it from the tree
for now.

thanks,

greg k-h