Re: [PATCH 17/19] selftests: Add -t tcp_authopt option for fcnal-test.sh

[Leonard Crestez]

On 9/25/21 4:52 AM, David Ahern wrote:
> On 9/21/21 10:15 AM, Leonard Crestez wrote:
> > This script is otherwise very slow to run!
>
> there are a lot of permutations to cover.

I believe that some of the sleeps are not necessary and could be 
replaced with waits.

> > Signed-off-by: Leonard Crestez <cdleonard@xxxxxxxxx>
> > ---
> >   tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
> > index 74a7580b6bde..484734db708f 100755
> > --- a/tools/testing/selftests/net/fcnal-test.sh
> > +++ b/tools/testing/selftests/net/fcnal-test.sh
> > @@ -1331,10 +1331,21 @@ ipv4_tcp()
> >   	log_subsection "With VRF"
> >   	setup "yes"
> >   	ipv4_tcp_vrf
> >   }
> >   
> > +
> > +only_tcp_authopt()
> > +{
> > +	log_section "TCP Authentication"
> > +	setup
> > +	set_sysctl net.ipv4.tcp_l3mdev_accept=0
> > +	log_subsection "IPv4 no VRF"
> > +	ipv4_tcp_authopt
>
> This feature needs to work with VRF from the beginning. v4, v6, with and
> without VRF.

I ignored the l3mdev feature because I'm not familiar with it but I'll 
go through it.

--
Regards,
Leonard