Re: [PATCH] net: ipa: Declare IPA firmware with MODULE_FIRMWARE()

From: Shawn Guo
Date: Sun Sep 26 2021 - 09:46:49 EST


On Sun, Sep 26, 2021 at 02:55:29PM +0800, Shawn Guo wrote:
> Declare IPA firmware with MODULE_FIRMWARE(), so that initramfs tools can
> build the firmware into initramfs image or warn on missing of the
> firmware.
>
> W: Possible missing firmware /lib/firmware/ipa_fws.mdt for module ipa
>
> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> ---
> drivers/net/ipa/ipa_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index cdfa98a76e1f..264bebc78d1e 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -545,6 +545,8 @@ static int ipa_firmware_load(struct device *dev)
> return ret;
> }
>
> +MODULE_FIRMWARE(IPA_FW_PATH_DEFAULT);
> +

Just reminded by Steev, .mdt file conventionally means we are using
split firmware. Building only .mdt file into initramfs is not
sufficient. So please disregard the patch.

Shawn

> static const struct of_device_id ipa_match[] = {
> {
> .compatible = "qcom,msm8998-ipa",
> --
> 2.17.1
>