Re: [PATCH] arm64: dts: qcom: Drop vdd-supply from qusb2-phy devices

From: Shawn Guo
Date: Sun Sep 26 2021 - 22:00:36 EST


On Mon, Sep 27, 2021 at 08:07:16AM +0800, Shawn Guo wrote:
> On Mon, Sep 27, 2021 at 12:58:19AM +0200, Konrad Dybcio wrote:
> >
> > On 26.09.2021 09:59, Shawn Guo wrote:
> > > Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in
> > > qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it
> > > from qusb2-phy devices on various boards.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> >
> > Why not add it to the regulators list instead? It's a valid regulator for this hw.
>
> I do not have enough information to be sure. Could you cook up a patch to
> update bindings and driver, if you think that's the case? I will be
> happy as long as that DTS, bindings and driver are on the same page.

Aha, I checked downstream kernel and vdd is indeed a valid supply for
qusb2_phy. Please disregard this patch, and I will update bindings and
driver instead. Thanks, Konrad!

Shawn