Re: [PATCH v2 2/2] arm64: dts: qcom: sm8250: Add Coresight support

From: Sai Prakash Ranjan
Date: Mon Sep 27 2021 - 00:26:50 EST

Hi Tao,

On 2021-09-27 08:13, Tao Zhang wrote:
Add the basic coresight components found on Qualcomm SM8250 Soc. The
basic coresight components include ETF, ETMs,STM and the related
ETM verification and use of Coresight components need Coresight
support in this device tree. Since the ETR sink needs SMMU support,
and SMMU has not been enabled on RB5. ETR is not added to this patch,
and it will be added once SMMU is enabled on RB5. ETF sink has been
added to the device tree for RB5.

RB5 board is based on SM8250 SoC and coresight is a SoC level IP (won't
change per board, although can be disabled per board) and as such these
coresight dt nodes should be in sm8250.dtsi (please look at other examples
in SM8150/SC7180/SC7280).

Similarly SMMU support is not per board (RB5), it's already supported
for SM8250 long time back (check for apps_smmu in sm8250.dtsi), so you
can add ETR support when you post v3 (note this patch which you have
posted should have been v3 as v2 was your previous version). You can just
post one patch with the coresight dt entries as the ETM driver patch is
already queued by Suzuki in coresight tree. You can use the following qcom
tree [1] when posting DT for QCOM devices (branch: for-next), also please
remember to *sort the nodes by address*.



QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation