Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

[Aditya Garg]

I tried Orlando Chamberlain's patch on 5.14.7 but still the SSD is not being recognised.

________________________________________
From: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx>
Sent: Sunday, September 26, 2021 8:44 AM
To: Aditya Garg; sagi@xxxxxxxxxxx; kbusch@xxxxxxxxxx
Cc: torvalds@xxxxxxxxxxxxxxxxxxxx; axboe@xxxxxx; hch@xxxxxx; linux-nvme@xxxxxxxxxxxxxxxxxxx; james.smart@xxxxxxxxxxxx; chaitanya.kulkarni@xxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; trivial@xxxxxxxxxx
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

On 26/9/21 18:07, Aditya Garg wrote:
> I checked out the proposal sent by Orlando Chamberlain to replace
> NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch on
> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html
> <http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html>.
> The , still causes panics to the T2 as described before. In the case of |, the
> kernel boots correctly without panicking the T2, but in case we are having Linux
> on an External Drive, which is my case, then the internal SSD doesn't seem to be
> recognised at all. I've tested the patch on 5.14.7. A screenshot of the GNOME
> Disks utility has been attached along with this mail.

I had some issues with the patch not applying automatically as I mixed up tabs and spaces,
(due to me copying stuff directly out of vim), so I had issues with getting patches to apply
automatically. I've checked that this file https://github.com/Redecorating/mbp-16.1-linux-wifi/blob/anbox-bt/1001-apple-t2-disable-nvme-gen-counter-quirk.patch
applies correctly for me (and github ci), so can you see if it still doesn't work with that?